Arik Hadas has posted comments on this change. Change subject: core: remove HandlersFactory.createVmPoolHandler ......................................................................
Patch Set 1: Allon, why don't we just remove this class? there is just one method remaining which is called from one place. Moreover, there are two cases in which I think we need factories: 1. to be able to replace the concrete factory with another one that returns other concrete implementations, but this class is final and it doesn't implement any interface so it is impossible to do it. 2. to put code that is called from several places in a common place, but it doesn't seems like it will be used in other places right? so if I'm not missing something here, I would prefer to remove the class. -- To view, visit http://gerrit.ovirt.org/21671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5033305edcf4bc1b18ef69596b9079d0ad080a61 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
