Liron Ar has posted comments on this change.
Change subject: core,webadmin: add isVm and isTemplate methods to VmEntityType
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
I suggest to have an helper methods in Disk to reduce the null checks, but
that's up to you.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmEntityType.java
Line 24: */
Line 25: public boolean isTemplateType() {
Line 26: return this == TEMPLATE ||
Line 27: this == INSTANCE_TYPE ||
Line 28: this == IMAGE_TYPE;
currently we can return this != VM or !isVmType to save comprasions but that's
up to you
Line 29: }
--
To view, visit http://gerrit.ovirt.org/21598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fc92031ab0afd08ab309a8ef6fd71a3fddb2204
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
