Kobi Ianko has posted comments on this change.

Change subject: webadmin: Disable new Pools popup when no Templates are 
available
......................................................................


Patch Set 1:

(3 comments)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
Line 626:         return "PoolListModel"; //$NON-NLS-1$
Line 627:     }
Line 628: 
Line 629:     public void updateOnReveal() {
Line 630:         AsyncDataProvider.getAllVmTemplates(new AsyncQuery(this,
Done
Line 631:                 new INewAsyncCallback() {
Line 632:                     @Override
Line 633:                     public void onSuccess(Object target, Object 
returnValue) {
Line 634:                         // if there are templates other than Blank, 
allow New command


Line 626:         return "PoolListModel"; //$NON-NLS-1$
Line 627:     }
Line 628: 
Line 629:     public void updateOnReveal() {
Line 630:         AsyncDataProvider.getAllVmTemplates(new AsyncQuery(this,
Done
Line 631:                 new INewAsyncCallback() {
Line 632:                     @Override
Line 633:                     public void onSuccess(Object target, Object 
returnValue) {
Line 634:                         // if there are templates other than Blank, 
allow New command


....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabPoolPresenter.java
Line 64: 
Line 65:     @Override
Line 66:     protected void onReveal() {
Line 67:         super.onReveal();
Line 68:         getModel().updateOnReveal();
Done, now I'm using the init method of PoolModelBehaviorBase which is activated 
every time the Pools popup screen is loaded
Line 69:     }


-- 
To view, visit http://gerrit.ovirt.org/21579
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb121d2e89922b04b8331db92e437cefc8b6b5c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to