Allon Mureinik has uploaded a new change for review. Change subject: core: Remove PowerMockito from AbstractQueryTest ......................................................................
core: Remove PowerMockito from AbstractQueryTest Removed the usage of PowerMockito from AbstractQueryTest in order to improve tests performance. PowerMokcito was (mainly) used to mock DbFacade.getInstance(), which is no longer needed since getQuery.getDbFacade() can be spied. Note that this pactch does NOT completely remove PowerMockito from all the queries' tests. For queries that require mocking static functions in helper classes (e.g., ImagesHandler, VmHandler), PowerMockito is still required, and the further refactoring requried to get rid of it is left for a future patch. In some classes PowerMockito calls were left untouched, and in some they had to be added explicitly since the base class no longer provides this functionallity. Change-Id: I3610e8ad9270d14a66475c67dd78cf4f8d1e64f0 --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetPermissionsToConsumeQuotaByQuotaIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetQuotasByAdElementIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetTemplatesRelatedToQuotaIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmByVmIdQueryTest.java 7 files changed, 26 insertions(+), 65 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/23/4023/1 -- To view, visit http://gerrit.ovirt.org/4023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3610e8ad9270d14a66475c67dd78cf4f8d1e64f0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
