Martin Peřina has posted comments on this change.
Change subject: core: fixing dual sequential PM scenario
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
Line 238: * fence the Host via the secondary agent if primary fails
Line 239: * @param lastStatus
Line 240: */
Line 241: private void tryOtherSequentialAgent(VDSStatus lastStatus,
VDSReturnValue vdsReturnValue) {
Line 242: executor = new FenceExecutor(getVds(),
getParameters().getAction());
Why are you using instance variable executor? Would be cleaner to use local
variable?
Line 243: if (executor.findProxyHost()) {
Line 244: vdsReturnValue =
executor.fence(FenceAgentOrder.Secondary);
Line 245: setFenceSucceeded(vdsReturnValue.getSucceeded());
Line 246: if (getFenceSucceeded()) {
--
To view, visit http://gerrit.ovirt.org/21774
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id88b22f06241c02f12dbc0efe32eb7f04063ed06
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
