Alon Bar-Lev has posted comments on this change.

Change subject: engine : Remove GetAllServerCpuListParameters class
......................................................................


Patch Set 21:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllServerCpuListQuery.java
Line 63:     }
Line 64: 
Line 65:     @Override
Line 66:     protected void executeQueryCommand() {
Line 67:         
getQueryReturnValue().setReturnValue(CpuFlagsManagerHandler.AllServerCpuList(
are you sure you need <Version> if the AllServerCpuList gets Version as 
parameter? I think it is implicit.
Line 68:                 getParameters().<Version>get(CoreParameters.VERSION)));
Line 69:     }
Line 70: 


-- 
To view, visit http://gerrit.ovirt.org/20416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifedb114e8a2294bb3868077c0d3466557b1b8d45
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to