Sahina Bose has uploaded a new change for review. Change subject: engine: Fix findbugs errors in GlusterTasksSyncJob ......................................................................
engine: Fix findbugs errors in GlusterTasksSyncJob Fixed a redudant null check find bug error Change-Id: I96647bf6b33569def8ddcf4846afcdbcdb28e786 Signed-off-by: Sahina Bose <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/16/21816/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java index 9ea1467..a7a48e0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java @@ -79,16 +79,14 @@ Map<Guid, GlusterAsyncTask> runningTasks = getProvider().getTaskListForCluster(cluster.getId()); if (runningTasks != null) { updateTasksInCluster(cluster, runningTasks); + tasksFromClustersMap.put(cluster.getId(), runningTasks.keySet()); } - tasksFromClustersMap.put(cluster.getId(), runningTasks == null ? null: runningTasks.keySet()); } catch (VdcBLLException e) { log.error("Error updating tasks from CLI", e); } } cleanUpOrphanTasks(tasksFromClustersMap); - - } private void updateTasksInCluster(final VDSGroup cluster, final Map<Guid, GlusterAsyncTask> runningTasks) { -- To view, visit http://gerrit.ovirt.org/21816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I96647bf6b33569def8ddcf4846afcdbcdb28e786 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
