Kanagaraj M has posted comments on this change.
Change subject: gluster: add Host UUID to volume status
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java
Line 44: volumeId = getParameters().getVolumeId();
Line 45: if (volumeId != null) {
Line 46: GlusterVolumeEntity volume =
getGlusterVolumeDao().getById(volumeId);
Line 47: if (volume == null) {
Line 48: throw new RuntimeException(String.format("Invalid
volume id %s", volumeId));
will do
Line 49: }
Line 50:
Line 51: brick = getBrick(getParameters().getBrickId());
Line 52:
getQueryReturnValue().setReturnValue(fetchAdvancedDetails(volume.getName()));
Line 50:
Line 51: brick = getBrick(getParameters().getBrickId());
Line 52:
getQueryReturnValue().setReturnValue(fetchAdvancedDetails(volume.getName()));
Line 53: } else {
Line 54: GlusterVolumeAdvancedDetails serviceDetails =
getServiceInfo();
will change
Line 55: if (serviceDetails != null) {
Line 56: List<GlusterServerService> serviceList =
serviceDetails.getServiceInfo();
Line 57: if (serviceList != null) {
Line 58: for (GlusterServerService service : serviceList) {
--
To view, visit http://gerrit.ovirt.org/21599
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cda0b69e3067d71d7c0fb8d71211a47691a68f5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
