Alon Bar-Lev has posted comments on this change.
Change subject: engine: Add infrastructure code for removal of parameter classes
......................................................................
Patch Set 20:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/Parameter.java
Line 12: private static final String SERIALIZE_UUID_KEY = "uuid";
Line 13: private static final Map<UUID, Parameter> parametersMap = new
HashMap<UUID, Parameter>();
Line 14:
Line 15: private String name;
Line 16: private transient Class javaType;
please explain me again... why can't we implement readObject() and reconstruct
the javaType out of javaTypeName?
Line 17: private String javaTypeName;
Line 18: private UUID uuid;
Line 19:
Line 20: /**
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ParametersMap.java
Line 18: paramsMap = new HashMap<Parameter, Serializable>();
Line 19: }
Line 20:
Line 21: public ParametersMap put(Parameter param, Object value) {
Line 22: if (value == null || (value instanceof String &&
"".equals((String) value))) {
I think that empty string is different from null and is a valid value.
Line 23: remove(param);
Line 24: } else {
Line 25: if (!isAssignableFrom(param.getJavaType(),
value.getClass())) {
Line 26: throw new
InvalidParameterValueException(param.getName(), param.getJavaType(),
value.getClass());
--
To view, visit http://gerrit.ovirt.org/20414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a0970e492c0eff561888a46b02e47645ff68fc3
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
