Martin Peřina has posted comments on this change.
Change subject: core: Move VDS to Maintenance only if StopSPM is successful
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
Line 64: spms.add(0, vds);
Line 65: } else {
Line 66: nonSpms.add(0, vds);
Line 67: }
Line 68: }
Ok, I modified existing code as least as possible according to new
functionality, but I still think that my original version is more readable
Line 69:
Line 70: // move to maintenance non SPM hosts first to minimize SPM
changes
Line 71: setVdsStatusToPrepareForMaintenance(nonSpms);
Line 72: setVdsStatusToPrepareForMaintenance(spms);
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ResetIrsVDSCommand.java
Line 46: // log to audit log if SpmStop command failed and SpmStop
result was not marked as ignored
Line 47: if (!getVDSReturnValue().getSucceeded()) {
Line 48: AuditLogableBase base = new AuditLogableBase(vdsId);
Line 49: AuditLogDirector.log(base,
AuditLogType.FAILED_TO_STOP_SPM_ON_HOST);
Line 50: }
Done
Line 51: }
--
To view, visit http://gerrit.ovirt.org/21231
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c58f9a9629d2e7a496f02c4dececeb842d44543
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
