Alon Bar-Lev has posted comments on this change.
Change subject: engine : Validate parameter in canDoAction
......................................................................
Patch Set 8:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ParametersValidator.java
Line 35: if (!params.containsAll(cmdParams.get(false))) {
Line 36: List<Parameter> copy = new
ArrayList(cmdParams.get(false));
Line 37: copy.removeAll(params);
Line 38: log.warnFormat("Required parameters {0} not found
in command.", getParameterNames(copy));
Line 39:
messages.add(VdcBllMessages.REQUIRED_PARAMETER_MISSING.name());
this added dependency between this module and BLL, which will not enable us to
reuse it for generic proposes.
I suggest to raise exception and handle the bll messages at the top level
module if it is actually part of bll.
Line 40: } else {
Line 41: params.removeAll(cmdParams.get(false));
Line 42: params.removeAll(cmdParams.get(true));
Line 43: if (params.size() > 0) {
--
To view, visit http://gerrit.ovirt.org/21485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15566c9177da28b2d47bbb6018fbfb61defcf3da
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
