Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: allow external plugins yum locking
......................................................................
Patch Set 4:
(2 comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/distro-rpm/packages.py
Line 68: osetupcons.RPMDistroEnv.VERSION_LOCK_FILTER
Line 69: ]:
Line 70: if line.find(check) != -1:
Line 71: modified = True
Line 72: continue
this continue what for? please do not use spaghetti programming.
for line in lines:
found = False
for token in tokens:
if line.find(token) != -1:
found = True
break
if not found:
content.append(line)
the break is ok as it is part of loop condition... that for some reason not
supported by python. so you are allowed break/continue at condition immediately
after for.
for (found=false, token=tokens; !found && token != null; token=token->next) {
}
Line 73: content.append(line)
Line 74: return (modified, content)
Line 75:
Line 76: @property
Line 69: ]:
Line 70: if line.find(check) != -1:
Line 71: modified = True
Line 72: continue
Line 73: content.append(line)
if I understand correctly this will leave file as-is.
Line 74: return (modified, content)
Line 75:
Line 76: @property
Line 77: def environment(self):
--
To view, visit http://gerrit.ovirt.org/21779
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5a33d3a09e1c5aa9fed8a08d81a4ce583c12797
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Spenser Shumaker <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
