anmolbabu has posted comments on this change.
Change subject: gluster : In the task tab, size of rebalanced files is shown
with units
......................................................................
Patch Set 16:
(3 comments)
Ok Moti saw them now.So,will address them in patch 18.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java
Line 39: long fromType = fromUnit.getUnitWeight();
Line 40: long toType = toUnit.getUnitWeight();
Line 41: return (size) * ((Math.pow(CONVERT_FACTOR, fromType)) /
(Math.pow(CONVERT_FACTOR, toType)));
Line 42: }
Line 43:
Done
Line 44: public static String autoConvert(long size , SizeUnit inUnit) {
Line 45: /*
Line 46: NumberFormat formatSize = NumberFormat.getInstance();
Line 47: formatSize.setMaximumFractionDigits(2);
Line 41: return (size) * ((Math.pow(CONVERT_FACTOR, fromType)) /
(Math.pow(CONVERT_FACTOR, toType)));
Line 42: }
Line 43:
Line 44: public static String autoConvert(long size , SizeUnit inUnit) {
Line 45: /*
Done
Line 46: NumberFormat formatSize = NumberFormat.getInstance();
Line 47: formatSize.setMaximumFractionDigits(2);
Line 48: formatSize.setMinimumFractionDigits(2);
Line 49: */
Line 46: NumberFormat formatSize = NumberFormat.getInstance();
Line 47: formatSize.setMaximumFractionDigits(2);
Line 48: formatSize.setMinimumFractionDigits(2);
Line 49: */
Line 50: for(long i = (SizeUnit.values())[SizeUnit.values().length -
1].getUnitWeight(); i >= inUnit.getUnitWeight(); i-- ) {
Done
Line 51: if(size/Math.pow(CONVERT_FACTOR, i-1) >= 1) {
Line 52: return ((String.valueOf(convert(size, inUnit,
SizeUnit.getUnit(i)).floatValue())).concat("
")).concat(SizeUnit.getUnit(i).toString());
Line 53: }
Line 54: }
--
To view, visit http://gerrit.ovirt.org/20511
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea6c90a098bfddfb616bc2b8ce58c9d0bb567f66
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
