Eli Mesika has posted comments on this change.
Change subject: core: Added GetVmDataByPoolIdQuery
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
patch is using new GetVmDataFromPoolByPoolId SP but no DB changes were issued
with this patch
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmDataByPoolIdQuery.java
Line 15: getQueryReturnValue().setReturnValue(DbFacade.getInstance()
Please note that Allon M has a pending change of all DbFacade.getInstance() for
all queries and make sure that your patch is aligned with those changes
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java
Line 289: return
getCallsHandler().executeRead("GetVmDataFromPoolByPoolId",
VMRowMapper.instance, parameterSource);
where this SP is defined , I can not see it in latest scripts and see no DB
patch either that installed it ....
--
To view, visit http://gerrit.ovirt.org/4024
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I390c9b49add6d004b1dc06e0e10eaf115c24243e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
