Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: update firewall for all services
......................................................................
Patch Set 7:
(4 comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/config/websocket_proxy.py
Line 74: self._enabled = True
Line 75:
Line 76: self._needStart = self.services.status(
Line 77: name='ovirt-websocket-proxy',
Line 78: )
It's already so (not by this change) - later in this file:
@plugin.event(
stage=plugin.Stages.STAGE_CLOSEUP,
condition=lambda self: (
self._needStart or
(
self._enabled and
not self.environment[
osetupcons.CoreEnv.DEVELOPER_MODE
]
)
),
)
Line 79:
Line 80: @plugin.event(
Line 81: stage=plugin.Stages.STAGE_CUSTOMIZATION,
Line 82: name=osetupcons.Stages.CONFIG_WEBSOCKET_PROXY_CUSTOMIZATION,
....................................................
File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py
Line 168: active_managers.append(manager)
Line 169:
Line 170: if (
Line 171: self.environment[osetupcons.ConfigEnv.UPDATE_FIREWALL] is
None and
Line 172: managers
supported_managers - those that we support
managers - supported_managers that exist. I actually called it
existing_managers in one of my internal versions but decided to go back to the
name 'managers' - perhaps existing_managers is better after all. User can
choose among all f them, not only among active_managers.
active_managers - managers that are active (actually, at most one). If user
chooses a non-active manager, they effectively change their firewall manager.
This all happens by existing otopi code, not here. For completeness we might
want to also do this here. Or revert this and only ask about active_managers -
this way, if there are no active_managers (but some do exist), we won't ask. In
previous comments you said you do want to ask about all of them, and I also
commented about this today in gerrit in a "main" comment (how do you call it?).
active_managers is used for the output to the user ('active' or 'inactive'),
and to make the active one default, below.
Line 173: ):
Line 174: self.dialog.note(
Line 175: text=_(
Line 176: 'Setup can automatically configure the firewall '
Line 195: )
Line 196:
Line 197: if (
Line 198: self.environment[osetupcons.ConfigEnv.FIREWALL_MANAGER]
is None
Line 199: and self.environment[osetupcons.ConfigEnv.UPDATE_FIREWALL]
Moved.
Because it has an elif below inside the big if.
Line 200: ):
Line 201: if len(managers) > 1:
Line 202: self.dialog.note(
Line 203: text=_(
Line 259: )
Line 260: self.environment[otopicons.NetEnv.FIREWALLD_ENABLE] = (
Line 261: self.environment[
Line 262: osetupcons.ConfigEnv.FIREWALL_MANAGER
Line 263: ] == 'firewalld'
Done. Although it might better be done in otopi.
Line 264: )
Line 265:
Line 266: @plugin.event(
Line 267: stage=plugin.Stages.STAGE_VALIDATION,
--
To view, visit http://gerrit.ovirt.org/20737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
