Arik Hadas has posted comments on this change. Change subject: core: add VMs from the same VDS to auto startup job in bulk ......................................................................
Patch Set 7: (1 comment) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java Line 425: _vdsManager.SuccededToRunVm(vm_guid); Line 426: } Line 427: Line 428: // Refrain from auto-start HA VM during its re-run attempts. Line 429: _autoVmsToRun.removeAll(_vmsToRerun); you know, it will be quicker to respond to the 2 options: 1. if the comment, it is the comment that was exist at line 424 before. do you have a suggestion how to rephrase it if it is not clear? 2. if the code, this line and the one below are equivalent to line 423-428: instead of going over the list and run only the relevant VMs, we remove the irrelevant VMs and pass only the one that is relevant to the event listener Line 430: // run all vms that crushed that marked with auto startup Line 431: getVdsEventListener().runFailedAutoStartVMs(_autoVmsToRun); Line 432: Line 433: // process all vms that their ip changed. -- To view, visit http://gerrit.ovirt.org/19504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I560383c8e73bb1728441fe5786954eba7ba88e60 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
