Arik Hadas has posted comments on this change. Change subject: core: change the retry to run failed HA VM frequency ......................................................................
Patch Set 8: @omer, 1. I tested in rerun treatments and it works. there shouldn't be a problem in rerun since rerun is triggered in two cases: a. when there's an error in the sync phase - in that case it triggers rerun and the respond to the 'run' called from within the AutoStartVmsRunner will return after all the rerun attempts were made. b. when there's an error in the async phase - VdsUpdateRuntimeInfo detects it and trigger the rerun. it means that the sync part was ended successfully, thus the VM was removed from the collection within the AutoStartVmsRunner, and in VdsUpdateRuntimeInfo we try to auto start HA VM only if it can't be rerun. 2. Indeed, starting and powering down the VM normally will be a problem in that case, because the AutoStartVmsRunner will try to run it. that case is not very likely to happen, but it's a wrong behavior - so now I'll check to see if the VM is down with error code before trying to run it. 3. I'm not sure about changing the frequency, I think it's over-complicated. IMO limiting the number of tries will be enough, what do you say? anyway, I fix it in a separate patch with a dedicated commit message so that it will be more clear. -- To view, visit http://gerrit.ovirt.org/19500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f8914efc73ac1ea4f4a2ec4e588d778e9002451 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
