Alon Bar-Lev has posted comments on this change.

Change subject: core: Disable PKCS#11 security provider
......................................................................


Patch Set 1:

also, because this file is noreplace we cannot be sure that it is being used.

first, I do not think we should fix rhel issues, if nss/pkcs11 leaks then all 
java applications are effected, and fix should be provided in rhel.

if not the solution of rhel should be non intrusive to other platforms, so at 
spec file and only if rhel:

1. install /etc/ovirt-engine/engine.conf.d/10-packaging-rhel.conf
---
ENGINE_PROPERTIES=${ENGINE_PROPERTIES} 
java.security.properties=/usr/share/ovirt-engine/conf/rhel.java.security.properties
---

2. /usr/share/ovirt-engine/conf/rhel.java.security.properties
---
whatever
---

3. user can always override the property with his own setting (not overriding 
the content but specify his own properties file).

thanks!

-- 
To view, visit http://gerrit.ovirt.org/21827
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I474b0ff84700f00c8dcab2c5eb8a6a2f3d13aeaf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to