Allon Mureinik has posted comments on this change.
Change subject: core: Plug disk to VM when adding a new disk
......................................................................
Patch Set 1: Code-Review-1
(3 comments)
Giving -1 due to un-intended(?) behavior change.
Also, please address Sergey's and Liron's comments.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 343:
Line 344: @Override
Line 345: protected void executeVmCommand() {
Line 346: getParameters().getDiskInfo().setId(Guid.newGuid());
Line 347: getParameters().setEntityInfo(new
EntityInfo(VdcObjectType.Disk, getParameters().getDiskInfo().getId()));
Changing params in the execute phase looks odd.
I'd fix the ctor rather than moving the code here.
Line 348: ImagesHandler.setDiskAlias(getParameters().getDiskInfo(),
getVm());
Line 349: if (DiskStorageType.IMAGE ==
getParameters().getDiskInfo().getDiskStorageType()) {
Line 350: createDiskBasedOnImage();
Line 351: } else {
Line 546: super.endSuccessfully();
Line 547: }
Line 548:
Line 549: private void plugDiskToVmIfNeeded() {
Line 550: if (getVm() != null && getParameters().getPlugDiskToVm() &&
getVm().getStatus() != VMStatus.Down) {
You should have a CDA to disallow getParameters().getPlugDiskToVm() == true
with a floating disk.
Line 551: HotPlugDiskToVmParameters params = new
HotPlugDiskToVmParameters(getVmId(), getParameters().getDiskInfo().getId());
Line 552:
Backend.getInstance().runInternalAction(VdcActionType.HotPlugDiskToVm, params);
Line 553: }
Line 554: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddDiskParameters.java
Line 6: public class AddDiskParameters extends VmDiskOperationParameterBase {
Line 7: private static final long serialVersionUID = -7832310521101821905L;
Line 8: private Guid vmSnapshotId;
Line 9: private Guid storageDomainId;
Line 10: private boolean plugDiskToVm = true;
If this patch is merged, you will change REST's behavior.
The default should remain false. If required, the UI can by default have a
checked checkbox to request plugging.
Line 11:
Line 12: public AddDiskParameters() {
Line 13: storageDomainId = Guid.Empty;
Line 14: }
--
To view, visit http://gerrit.ovirt.org/21851
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9778bcaf21b346a55992590159cabd8d78f0c66
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
