Allon Mureinik has posted comments on this change. Change subject: frontend: ignore "class too big" findbug on ApplicationConstants ......................................................................
Patch Set 1: @Itamar - as far as I can recall from the code, FB has a fail-fast mechanism, which quits a file's processing after triggering this warning. Having said that, I'm all for this patch (note the +2) - all I'm asking for is to run a /jenkins/ FB analysis on this patch and make sure it does not crash. I'm pretty sure this is doable, but if you prefer, I can merge and revert if it DOES cause a problem. -- To view, visit http://gerrit.ovirt.org/21699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9e2672cda097af1e0bd43a4cc37671e14c483fa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
