Moti Asayag has uploaded a new change for review. Change subject: engine: Cleanup of MultipleActionsRunner ......................................................................
engine: Cleanup of MultipleActionsRunner Change-Id: Ia679a00f961b0d2e88d0815df374d7374bf4e7ab Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/25/21925/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java index a72fbd9..ca11194 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java @@ -19,9 +19,9 @@ private static Log log = LogFactory.getLog(MultipleActionsRunner.class); private final static int CONCURRENT_ACTIONS = 10; - private VdcActionType _actionType = VdcActionType.Unknown; - private List<VdcActionParametersBase> _parameters; - private final ArrayList<CommandBase<?>> _commands = new ArrayList<CommandBase<?>>(); + private VdcActionType actionType = VdcActionType.Unknown; + private List<VdcActionParametersBase> parameters; + private final ArrayList<CommandBase<?>> commands = new ArrayList<CommandBase<?>>(); protected boolean isInternal; /** @@ -35,23 +35,23 @@ private ExecutionContext executionContext; public MultipleActionsRunner(VdcActionType actionType, List<VdcActionParametersBase> parameters, boolean isInternal) { - _actionType = actionType; - _parameters = parameters; + this.actionType = actionType; + this.parameters = parameters; this.isInternal = isInternal; } protected List<VdcActionParametersBase> getParameters() { - return _parameters; + return parameters; } protected ArrayList<CommandBase<?>> getCommands() { - return _commands; + return commands; } public ArrayList<VdcReturnValueBase> Execute() { // sanity - don't do anything if no parameters passed - if (_parameters == null || _parameters.isEmpty()) { - log.infoFormat("{0} of type {1} invoked with no actions", this.getClass().getSimpleName(), _actionType); + if (parameters == null || parameters.isEmpty()) { + log.infoFormat("{0} of type {1} invoked with no actions", this.getClass().getSimpleName(), actionType); return new ArrayList<VdcReturnValueBase>(); } @@ -62,7 +62,7 @@ parameter.setMultipleAction(true); returnValue = ExecutionHandler.evaluateCorrelationId(parameter); if (returnValue == null) { - CommandBase<?> command = CommandsFactory.CreateCommand(_actionType, parameter); + CommandBase<?> command = CommandsFactory.CreateCommand(actionType, parameter); command.setInternalExecution(isInternal); getCommands().add(command); } else { @@ -96,7 +96,7 @@ }); } } catch (RuntimeException e) { - log.error("Failed to execute multiple actions of type: " + _actionType, e); + log.error("Failed to execute multiple actions of type: " + actionType, e); } return returnValues; } -- To view, visit http://gerrit.ovirt.org/21925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia679a00f961b0d2e88d0815df374d7374bf4e7ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
