Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: update firewall for all services
......................................................................


Patch Set 18:

(1 comment)

....................................................
File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py
Line 353:                 firewall_manager = None
Line 354:                 for manager in self._available_managers:
Line 355:                     if manager.name == response:
Line 356:                         firewall_manager = manager
Line 357:                         break
to get default if nothing found:

next((m for m in self._available_managers if m.name == response), None)
Line 358: 
Line 359:                 self.environment[
Line 360:                     osetupcons.ConfigEnv.FIREWALL_MANAGER
Line 361:                 ] = manager.name


-- 
To view, visit http://gerrit.ovirt.org/20737
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to