Liran Zelkha has posted comments on this change.
Change subject: engine: Make VDSPartial, a partially loaded VDS object
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
Line 350: public VDS getPartial(Guid vdsId) {
Line 351: VDS vdsPartial = new VDS();
Line 352:
Line 353: // TODO: A future patch will load this from cache
Line 354:
vdsPartial.setStaticData(DbFacade.getInstance().getVdsStaticDao().get(vdsId));
And still, those 3 reads are much faster than reading a full VDS. I think it is
very readable, and if it performs well - we should keep it. The cache patch
will be submitted tomorrow...
Line 355:
vdsPartial.setDynamicData(DbFacade.getInstance().getVdsDynamicDao().get(vdsId));
Line 356:
Line 357: // TODO: A future patch will load this from cache
Line 358: VDSGroup group =
DbFacade.getInstance().getVdsGroupDao().get(vdsPartial.getVdsGroupId());
--
To view, visit http://gerrit.ovirt.org/21662
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d72c21f1686c4031607d793bbbefcc3e45e98cb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
