Yair Zaslavsky has posted comments on this change.
Change subject: core: Change LDAP identifer to ExternalId
......................................................................
Patch Set 6:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java
Line 95: */
Line 96: private static void updateDBUserFromADUser(DbUser dbUser, LdapUser
ldapUser, HashSet<Guid> updatedUsers) {
Line 97: boolean succeeded = false;
Line 98:
Line 99: if (ldapUser == null ||
!ldapUser.getUserId().equals(dbUser.getExternalId())) {
no need to check equation with Guid.Empty?
Line 100: if (dbUser.getStatus() != 0) {
Line 101: log.warnFormat("User {0} not found in directory
server, its status switched to InActive",
Line 102: dbUser.getFirstName());
Line 103: dbUser.setStatus(0);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapGetAdGroupByGroupIdCommand.java
Line 33: if (searchResult != null) {
Line 34: GroupSearchResult result = (GroupSearchResult)
searchResult;
Line 35: ExternalId groupId = result.getId();
Line 36:
Line 37: if (ObjectUtils.notEqual(getGroupId(), groupId)) {
Why did you switch here to objectUtils ?
Line 38: /**
Line 39: * Cannot find group - group is Inactive
Line 40: */
Line 41: group = new LdapGroup(getGroupId());
--
To view, visit http://gerrit.ovirt.org/19482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib464dfc2353158fccc92922893614a35b5c06081
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
