Sergey Gotliv has uploaded a new change for review. Change subject: webadmin: Add icons to bootable and shareable columns ......................................................................
webadmin: Add icons to bootable and shareable columns Up until now Bootable and Shareable columns in Add Virtual Disk window missed headers. This patch adding their icons as headers. Change-Id: I776739681d9ae47d6d7dc92115dc7269e2495127 Signed-off-by: Sergey Gotliv <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/21959/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java index c225abd..28d2b13 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java @@ -401,6 +401,9 @@ ); internalDiskTable.addColumn(DisksViewColumns.readOnlyCheckboxColumn, readOnlyColumnHeader, "30px"); //$NON-NLS-1$ + SafeHtml bootableColumnHeader = templates.imageWithTitle(SafeHtmlUtils.fromTrustedString( + AbstractImagePrototype.create(resources.bootableDiskIcon()).getHTML()), constants.bootable() + ); internalDiskTable.addColumn(new ImageResourceColumn<EntityModel>() { @Override public ImageResource getValue(EntityModel object) { @@ -408,8 +411,11 @@ setTitle(disk.isBoot() ? constants.bootableDisk() : null); return disk.isBoot() ? resources.bootableDiskIcon() : null; } - }, "", "30px"); //$NON-NLS-1$ //$NON-NLS-2$ + }, bootableColumnHeader, "30px"); //$NON-NLS-1$ //$NON-NLS-2$ + SafeHtml shareableColumnHeader = templates.imageWithTitle(SafeHtmlUtils.fromTrustedString( + AbstractImagePrototype.create(resources.shareableDiskIcon()).getHTML()), constants.shareable() + ); internalDiskTable.addColumn(new ImageResourceColumn<EntityModel>() { @Override public ImageResource getValue(EntityModel object) { @@ -417,7 +423,7 @@ setTitle(disk.isShareable() ? constants.shareable() : null); return disk.isShareable() ? resources.shareableDiskIcon() : null; } - }, "", "30px"); //$NON-NLS-1$ //$NON-NLS-2$ + }, shareableColumnHeader, "30px"); //$NON-NLS-1$ //$NON-NLS-2$ internalDiskTable.setWidth("100%", true); //$NON-NLS-1$ internalDiskTable.setHeight("100%"); //$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/21959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I776739681d9ae47d6d7dc92115dc7269e2495127 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
