Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: print proper message suggesting to run as root ......................................................................
Patch Set 1: Code-Review+1 (1 comment) .................................................... File packaging/setup/bin/ovirt-engine-setup.env.in All three scripts are in the package 'ovirt-engine-setup', it's not that weird that a file that is sourced by all of them will be named the same as the package. Perhaps we should rename the package... I don't mind renaming it, but don't have a really good name - perhaps ovirt-engine-setup-common ? If we don't rename, it can be helpful to add a comment in the beginning saying it's sourced by all of them Line 1: Line 2: DEV_PYTHON_DIR="@DEV_PYTHON_DIR@" Line 3: DEVMODE="@DEVMODE@" Line 4: -- To view, visit http://gerrit.ovirt.org/21980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3850b5c474e7bae47f2b240c19dee690d6c9e3ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
