Allon Mureinik has uploaded a new change for review. Change subject: core: rm unused VersionSupport.isActionSupported ......................................................................
core: rm unused VersionSupport.isActionSupported Change-Id: I20b0ff807b4815971f4c371bf8ffb0493fabe19e Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VersionSupport.java 1 file changed, 0 insertions(+), 20 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/86/21986/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VersionSupport.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VersionSupport.java index 1737d1e..ad25a06 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VersionSupport.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VersionSupport.java @@ -4,12 +4,10 @@ import java.util.Set; import org.apache.commons.lang.StringUtils; -import org.ovirt.engine.core.common.action.VdcActionType; import org.ovirt.engine.core.common.businessentities.VDS; import org.ovirt.engine.core.common.config.Config; import org.ovirt.engine.core.common.config.ConfigValues; import org.ovirt.engine.core.compat.Version; -import org.ovirt.engine.core.dal.dbbroker.DbFacade; import org.ovirt.engine.core.common.errors.VdcBllMessages; import org.ovirt.engine.core.utils.log.Log; import org.ovirt.engine.core.utils.log.LogFactory; @@ -54,23 +52,5 @@ } } return isVersionSupported; - } - - /** - * @param version - * Compatibility version to check for. - * @param action - * The action type to check for - * @return <code>true</code> if the action is supported for the version, <code>false</code> if it's not. - * @throws NullPointerException - * if an entry is missing from the action_version_map table for the queried action type - */ - public static boolean isActionSupported(VdcActionType action, Version version) { - Version minimalVersion = - new Version(DbFacade.getInstance() - .getActionGroupDao() - .getActionVersionMapByActionType(action) - .getcluster_minimal_version()); - return version.compareTo(minimalVersion) >= 0; } } -- To view, visit http://gerrit.ovirt.org/21986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I20b0ff807b4815971f4c371bf8ffb0493fabe19e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
