Allon Mureinik has uploaded a new change for review. Change subject: core: Make Event immutable ......................................................................
core: Make Event immutable Removed unused setters from the Event class. Once an Event is created, it makes no sense to modify it, and having the class immutable is a good defensive practice for this kind of data objects. Change-Id: I92eaad099f975d279fb1ab6a9c70112e7ea194d5 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/Event.java 1 file changed, 0 insertions(+), 20 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/00/22000/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/Event.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/Event.java index 7d5d5a3..c07cfa3 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/Event.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/Event.java @@ -22,40 +22,20 @@ return storagePoolId; } - public void setStoragePoolId(Guid storagePoolId) { - this.storagePoolId = storagePoolId; - } - public EventType getEventType() { return eventType; - } - - public void setEventType(EventType eventType) { - this.eventType = eventType; } public String getDescription() { return description; } - public void setDescription(String description) { - this.description = description; - } - public Guid getDomainId() { return domainId; } - public void setDomainId(Guid domainId) { - this.domainId = domainId; - } - public Guid getVdsId() { return vdsId; - } - - public void setVdsId(Guid vdsId) { - this.vdsId = vdsId; } @Override -- To view, visit http://gerrit.ovirt.org/22000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I92eaad099f975d279fb1ab6a9c70112e7ea194d5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
