Sahina Bose has posted comments on this change.
Change subject: gluster: Proper checking before retriving volume in
eventMessageLogger
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java
Line 222: }
Line 223:
Line 224: public void eventMessageLogger(GlusterAsyncTask task,
JobExecutionStatus oldStatus, VDSGroup cluster) {
Line 225: GlusterVolumeEntity volume;
Line 226: if ( getVolumeDao().getVolumeByGlusterTask(task.getTaskId())
!= null) {
Can you change this to
GlusterVolumeEntity volume =
getVolumeDao().getVolumeByGlusterTask(task.getTaskId();
if (volume == null) ...
Line 227: volume =
getVolumeDao().getVolumeByGlusterTask(task.getTaskId());
Line 228: }
Line 229: else {
Line 230: String vol = task.getTaskParameters().getVolumeName();
Line 226: if ( getVolumeDao().getVolumeByGlusterTask(task.getTaskId())
!= null) {
Line 227: volume =
getVolumeDao().getVolumeByGlusterTask(task.getTaskId());
Line 228: }
Line 229: else {
Line 230: String vol = task.getTaskParameters().getVolumeName();
Check that task.getTaskParameters != null
Line 231: volume = getVolumeDao().getByName(cluster.getId(), vol);
Line 232: }
Line 233: if (JobExecutionStatus.ABORTED == task.getStatus() ||
JobExecutionStatus.FINISHED == task.getStatus() || JobExecutionStatus.FAILED ==
task.getStatus()){
Line 234: if(oldStatus != task.getStatus()){
--
To view, visit http://gerrit.ovirt.org/21949
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78367afc8771b2adb6b653f5d23bdbfe28e126d2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Darshan N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
