Hello Alissa Bonas,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/22017

to review the following change.

Change subject: DO NOT MERGE!!! frontend: ignore "class too big" findbug on 
ApplicationConstants
......................................................................

DO NOT MERGE!!! frontend: ignore "class too big" findbug on ApplicationConstants

!!! DO NOT MERGE !!!

Add to excluded warnings filter the "class too big" warning
generated on ApplicationConstants class.

Change-Id: If9e2672cda097af1e0bd43a4cc37671e14c483fa
Signed-off-by: Alissa Bonas <[email protected]>
---
M frontend/webadmin/modules/webadmin/exclude-filters.xml
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/17/22017/1

diff --git a/frontend/webadmin/modules/webadmin/exclude-filters.xml 
b/frontend/webadmin/modules/webadmin/exclude-filters.xml
index 43110c8..4a1a924 100644
--- a/frontend/webadmin/modules/webadmin/exclude-filters.xml
+++ b/frontend/webadmin/modules/webadmin/exclude-filters.xml
@@ -238,4 +238,11 @@
        <Method name="hashCode"/>
        <Bug code="DM"/>
      </Match>
+
+   <Match>
+     <Class name="org.ovirt.engine.ui.webadmin.ApplicationConstants" />
+     <Bug pattern="SKIPPED_CLASS_TOO_BIG"/>
+   </Match>
+
+
 </FindBugsFilter>


-- 
To view, visit http://gerrit.ovirt.org/22017
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9e2672cda097af1e0bd43a4cc37671e14c483fa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to