Lior Vernia has uploaded a new change for review. Change subject: webadmin: Created interdependence between profile actions ......................................................................
webadmin: Created interdependence between profile actions When creating multiple profiles from the Add/Edit Network dialog, the backend actions were run using Frontend.RunMultipleAction() which caused the validity of the actions to be checked independently. However, the validity should be checked in an interdependent manner (i.e. serially), because the completion of one command can create conditions where another command is invalid (e.g. if two commands try to create two vNIC profiles with the same name). Solved by running Frontend.RunMultipleActions() instead. Change-Id: I3d94298b0bd29be423d0b1b90c2174630de96092 Bug-Url: https://bugzilla.redhat.com/1031577 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/20/22020/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java index 882e860..8fe5822 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java @@ -33,9 +33,9 @@ import org.ovirt.engine.ui.uicompat.ConstantsManager; import org.ovirt.engine.ui.uicompat.Event; import org.ovirt.engine.ui.uicompat.EventArgs; -import org.ovirt.engine.ui.uicompat.FrontendMultipleActionAsyncResult; +import org.ovirt.engine.ui.uicompat.FrontendActionAsyncResult; import org.ovirt.engine.ui.uicompat.IEventListener; -import org.ovirt.engine.ui.uicompat.IFrontendMultipleActionAsyncCallback; +import org.ovirt.engine.ui.uicompat.IFrontendActionAsyncCallback; public abstract class NetworkModel extends Model { @@ -534,14 +534,14 @@ } } - IFrontendMultipleActionAsyncCallback callback = new IFrontendMultipleActionAsyncCallback() { + IFrontendActionAsyncCallback callback = new IFrontendActionAsyncCallback() { @Override - public void executed(FrontendMultipleActionAsyncResult result) { + public void executed(FrontendActionAsyncResult result) { stopProgress(); cancel(); } }; - Frontend.RunMultipleAction(VdcActionType.AddVnicProfile, paramlist, callback, null); + Frontend.RunMultipleActions(VdcActionType.AddVnicProfile, paramlist, callback); } void cancel() { -- To view, visit http://gerrit.ovirt.org/22020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3d94298b0bd29be423d0b1b90c2174630de96092 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
