Martin Peřina has posted comments on this change. Change subject: core: Move VDS to Maintenance only if StopSPM is successful ......................................................................
Patch Set 5: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java Line 38 Line 39 Line 40 Line 41 Line 42 _vdsGroupIds were filled in canDoAction, then transformed to HashSet<Guid> clustersAsSet (complete nonsense to fill all values in ArrayList and after that create new instance of HashSet and apply addAll to append those into the set) and tested. Also the values in _vdsGroupIds were used in executeCommand to update network status. So since _vdsGroupIds will be used only in canDoAction, I removed it completely and add values only to clustersAsSet. And during executeCommand() I have to create new set of clusters from VDSs for which SetVdsStatus command was successfull -- To view, visit http://gerrit.ovirt.org/21231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c58f9a9629d2e7a496f02c4dececeb842d44543 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
