Ori Liel has posted comments on this change.

Change subject: restapi: correct status code for add brick when volume is down.
......................................................................


Patch Set 1: Code-Review+2

This change in itself is good, so I approve it. But it sounds like you might 
have a problem in dpPopulate(). I advise you to look into what happens when 
'populate' header is passed  in the request (in this flow, populate() invokes 
doPopulate())

-- 
To view, visit http://gerrit.ovirt.org/21941
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6c680383ea75d898a6496c86daabe38630f9d18
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Darshan N <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to