Roy Golan has posted comments on this change.
Change subject: engine: scheduling: allow placement overbooking in cluster level
......................................................................
Patch Set 13: Code-Review+1
(2 comments)
get a UI +1
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
Line 233: && Config.<Boolean>
GetValue(ConfigValues.SchedulerAllowOverBooking)) {
Line 234: log.debugFormat("scheduler: cluster ({0}) lock is
skipped (cluster is allowed to overbook)",
Line 235: cluster.getName());
Line 236: } else {
Line 237: clusterLockMap.get(cluster.getId()).acquire();
open yourself a bug about a memory leak of this lock map
Line 238: }
Line 239: List<VDS> vdsList = getVdsDAO()
Line 240: .getAllForVdsGroupWithStatus(cluster.getId(),
VDSStatus.Up);
Line 241: updateInitialHostList(vdsList, hostBlackList, true);
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/OptimizationType.java
Line 6: * represented by a unique binary number to allow future combinations
Line 7: * cluster's optimizations
Line 8: * <p>
Line 9: * none - 0000
Line 10: * optimize_for_speed - 0001
change this bit notation. you currently don't do that
Line 11: * allow_overbooking - 0002
Line 12: */
Line 13: public enum OptimizationType {
Line 14: NONE(0),
--
To view, visit http://gerrit.ovirt.org/19272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If52abf9974ab71b1f8d52ca268dac8dc39b89dc8
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
