Lior Vernia has posted comments on this change. Change subject: webadmin: Simplify VnicProfile flow in NetworkModel ......................................................................
Patch Set 1: (1 comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java Line 161 Line 162 Line 163 Line 164 Line 165 It's only required if I'm allowing to edit the profiles of an existing VM network, since only in that case there are pre-existing profiles that might be removed from the engine (no profiles exist if the network is new or currently non-VM). That's exactly what we're trying to block now, because if a network already exists and is a VM network then its profiles can be added/removed through the dedicated Network/Profiles subtab. It just causes trouble to have the same functionality available from the dialog too (need to duplicate validation code and so forth). -- To view, visit http://gerrit.ovirt.org/22019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21b632e7625e24a6ecb28e278639805990f6af41 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
