Gilad Chaplik has posted comments on this change.
Change subject: engine: Adding Speed optimization option to the scheduler
......................................................................
Patch Set 13:
(3 comments)
Thanks Roy :)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java
Line 40:
Line 41: @Override
Line 42: protected boolean canDoAction() {
Line 43: boolean result = super.canDoAction();
Line 44: return result && checkOptimizationType();
removing this validation since I'm changing the optimization-type type to enum.
Line 45: }
Line 46:
Line 47: private boolean checkOptimizationType() {
Line 48: int optimizationType = getVdsGroup().getOptimizationType();
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
Line 75: private Map<String, String> clusterPolicyProperties;
Line 76: private boolean detectEmulatedMachine;
Line 77:
Line 78: private int optimizationType;
Line 79:
Done, changed to an enum.
Line 80: public VDSGroup() {
Line 81: migrateOnError = MigrateOnErrorOptions.YES;
Line 82: name = "";
Line 83: virtService = true;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1544: HostPreparingForMaintenanceIdleTime,
Line 1545:
Line 1546: @TypeConverterAttribute(Integer.class)
Line 1547: @DefaultValueAttribute("10")
Line 1548: SpeedOptimizationSchedulingThreshold,
http://gerrit.ovirt.org/#/c/19270/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
Line 1549:
Line 1550: Invalid;
--
To view, visit http://gerrit.ovirt.org/19270
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0784f89648093e650be73fcc3d850a4854d53c1a
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
