Martin Betak has posted comments on this change. Change subject: restapi: Add Reboot support ......................................................................
Patch Set 15: (1 comment) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 2269: <xs:sequence> Line 2270: <xs:element name="enabled" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 2271: <xs:element name="priority" type="xs:int" minOccurs="0" maxOccurs="1"/> Line 2272: <xs:element name="powerdown_forced" type="xs:boolean" minOccurs="0" maxOccurs="1" /> Line 2273: <xs:element name="graceful_timeout" type="xs:int" minOccurs="0" maxOccurs="1" /> Actually on closer look, there may be some problem using the GracePeriod type. In the current implementation the user can specify a value for the timeout for this specific VM or can leave it unset (null) and then the global engine-wide config value will be used. From the code generated for GracePeriod I see that isSetExpiry always return true and I wouldn't be able to set null value for this field via REST. Using plain xs:int provides me with correct isSet... method and a nullable Integer field that has this ability. Line 2274: </xs:sequence> Line 2275: </xs:complexType> Line 2276: Line 2277: <xs:element name="display" type="Display"/> -- To view, visit http://gerrit.ovirt.org/16194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9a5007a1364392830e4112e57ec54a7025fee02 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
