Kanagaraj M has posted comments on this change.

Change subject: gluster: fix repeated words while removing user role or 
permission
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 349: RUN_VM_FAILED=Cannot run VM ${VmName} on Host ${VdsName}. Error: 
${ErrMsg}
Line 350: USER_ADD_PERMISSION=User/Group ${SubjectName} was granted permission 
for Role ${RoleName} on ${VdcObjectType}, by ${UserName}.
Line 351: USER_ADD_PERMISSION_FAILED=User ${UserName} failed to grant 
permission for Role ${RoleName} on ${VdcObjectType} to User/Group 
${SubjectName}.
Line 352: USER_REMOVE_PERMISSION=User/Group ${SubjectName} Role ${RoleName} 
permission was removed from ${VdcObjectType} by ${UserName}
Line 353: USER_REMOVE_PERMISSION_FAILED=User ${UserName} failed to remove 
permission for Role ${RoleName} from ${VdcObjectType} to User/Group 
${SubjectName}
but this could be a problem if a permission is set on a particular entity like 
host or volume. That time the message should have both type (host or volume or 
..) and the name of the entity (volume name)
Line 354: USER_ADD_ROLE=Role ${RoleName} granted to ${UserName}
Line 355: USER_ADD_ROLE_FAILED=Failed to grant role ${RoleName} (User 
${UserName})
Line 356: USER_REMOVE_ROLE=Role ${RoleName} removed from ${UserName}
Line 357: USER_REMOVE_ROLE_FAILED=Failed to remove role ${RoleName} (User 
${UserName})


-- 
To view, visit http://gerrit.ovirt.org/21735
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ec4962877168768879e45b10aa65d9416f54831
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to