Kanagaraj M has posted comments on this change.
Change subject: gluster: fix to remove multiple host when hosts are in
maintenance
......................................................................
Patch Set 2:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
Line 151: log.infoFormat("Server {0} has been removed directly
using the gluster CLI. Removing it from engine as well.",
Line 152: server.getName());
Line 153: logUtil.logServerMessage(server,
AuditLogType.GLUSTER_SERVER_REMOVED_FROM_CLI);
Line 154: try {
Line 155: removeServerFromDb(server);
this should be inside lock
Line 156: // remove the server from resource manager TODO
add lock
Line 157: try (EngineLock lock =
getGlusterUtil().acquireGlusterLockWait(server.getVdsGroupId())) {
Line 158: runVdsCommand(VDSCommandType.RemoveVds, new
RemoveVdsVDSCommandParameters(server.getId()));
Line 159: }
Line 152: server.getName());
Line 153: logUtil.logServerMessage(server,
AuditLogType.GLUSTER_SERVER_REMOVED_FROM_CLI);
Line 154: try {
Line 155: removeServerFromDb(server);
Line 156: // remove the server from resource manager TODO
add lock
TODO ?
Line 157: try (EngineLock lock =
getGlusterUtil().acquireGlusterLockWait(server.getVdsGroupId())) {
Line 158: runVdsCommand(VDSCommandType.RemoveVds, new
RemoveVdsVDSCommandParameters(server.getId()));
Line 159: }
Line 160: serverRemoved = true;
Line 153: logUtil.logServerMessage(server,
AuditLogType.GLUSTER_SERVER_REMOVED_FROM_CLI);
Line 154: try {
Line 155: removeServerFromDb(server);
Line 156: // remove the server from resource manager TODO
add lock
Line 157: try (EngineLock lock =
getGlusterUtil().acquireGlusterLockWait(server.getVdsGroupId())) {
lock should be acquired for vdsId, if not its deadlock here
Line 158: runVdsCommand(VDSCommandType.RemoveVds, new
RemoveVdsVDSCommandParameters(server.getId()));
Line 159: }
Line 160: serverRemoved = true;
Line 161: } catch (Exception e) {
--
To view, visit http://gerrit.ovirt.org/21865
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f74af59dc0723eda46ac1b7c53b2a980c49fda4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
