Martin Sivák has posted comments on this change.
Change subject: agent: configurable host score factors
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
....................................................
File ovirt_hosted_engine_ha/agent/Makefile.am
Line 53: agent-log.conf \
Line 54: $(NULL)
Line 55:
Line 56: EXTRA_DIST = \
Line 57: agent.conf \
Are you sure about this? I am no automake wizzard, but I would think that the
DATA line is enough.
Line 58: agent-log.conf.in \
Line 59: constants.py.in \
Line 60: $(NULL)
Line 61:
....................................................
File ovirt_hosted_engine_ha/agent/hosted_engine.py
Line 161: pass
Line 162:
Line 163: # When these are used they're expected to be numeric types
Line 164: for k, v in score.iteritems():
Line 165: if k.startswith('cpu-load-penalty-'):
I do not like this much.. it should at least be part of the constants or
something..
Line 166: score[k] = float(v)
Line 167: else:
Line 168: score[k] = int(v)
Line 169:
--
To view, visit http://gerrit.ovirt.org/22056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If485283c133eb517c9a3036ff42d1cd962a1697d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
