Sergey Gotliv has posted comments on this change.
Change subject: core: prevent maintenance when domain is sill in use
......................................................................
Patch Set 2:
(1 comment)
partially reviewed.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatus.java
Line 19: }
Line 20:
Line 21: public boolean isLocked() {
Line 22: return this == Locked || this == MovingToMaintenance;
Line 23: }
I have to think about it, my instinct says - no...
I think that our state machine is over complicated and you adding new state and
then hiding it inside isLocked...
--
To view, visit http://gerrit.ovirt.org/22045
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55cd5aa6a6dc32f374a4bb21b159d3cb30da65f5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
