Martin Peřina has posted comments on this change.
Change subject: tools: Fixing edit action of manage-domains
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
Line 528: authModeEntry.setValueForDomain(domainName, authMode);
Line 529: ldapProviderTypesEntry.setValueForDomain(domainName,
ldapProviderType.name());
Line 530:
Line 531: String ldapServersStr =
parser.getArg(Arguments.ldapServers.name());
Line 532: setLdapServersPerDomain(domainName, ldapServersEntry,
ldapServersStr);
I think we have a bug in here. It's using only ldapServers specified as a cmd
line arg and not those find in DNS if cmd line arg is not specified. So correct
code should be:
setLdapServersPerDomain(domainName, ldapServersEntry,
StringUtils.join(ldapServers, ","));
And line 531 can be removed.
Line 533:
Line 534:
Line 535: testConfiguration(domainName,
Line 536: domainNameEntry,
--
To view, visit http://gerrit.ovirt.org/22063
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f86b8ce2c697931b9c8388ea87fe07d557530c6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
