Allon Mureinik has uploaded a new change for review. Change subject: core: init VmTemplateHandler.BlankVmTemplateId ......................................................................
core: init VmTemplateHandler.BlankVmTemplateId Removed the redundant initialization of BlankVmTemplateId from the Init() function and made the dada member final, as this is conceptually a constant. Change-Id: I62599b6516865967783b7f3ac8092d42fe40aed8 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/41/22141/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java index 9fc6935..6d2e795 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java @@ -21,7 +21,7 @@ import org.ovirt.engine.core.utils.transaction.TransactionSupport; public class VmTemplateHandler { - protected static Guid BlankVmTemplateId = Guid.Empty; + protected static final Guid BlankVmTemplateId = Guid.Empty; protected final static String BLANK_VM_TEMPLATE_NAME = "Blank"; private static ObjectIdentityChecker mUpdateVmTemplate; @@ -34,7 +34,6 @@ public static void Init() { final Class<?>[] inspectedClassNames = new Class<?>[] { VmBase.class, VmTemplate.class }; mUpdateVmTemplate = new ObjectIdentityChecker(VmTemplateHandler.class); - BlankVmTemplateId = new Guid("00000000-0000-0000-0000-000000000000"); for (Pair<EditableField, String> pair : BaseHandler.extractAnnotatedFields(EditableField.class, (inspectedClassNames))) { -- To view, visit http://gerrit.ovirt.org/22141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I62599b6516865967783b7f3ac8092d42fe40aed8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
