Allon Mureinik has uploaded a new change for review. Change subject: core: Use longs to represent dates in QueryData ......................................................................
core: Use longs to represent dates in QueryData Use longs representing the amount of milliseconds since the epoch instead of Data instances in order to prevent accidental change of QueryData's internal members externally. Besides being a good defensive practice, this patch solves the EI_EXPOSE_REP and EI_EXPOSE_REP2 FindBugs warnings on this class. Change-Id: I9eb83c123a4fd9a1b2abc3bdb74d91a1391245d2 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 2 files changed, 5 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/44/22144/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java index fa01c8d..9bebaeb 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java @@ -1,16 +1,14 @@ package org.ovirt.engine.core.bll; -import java.util.Date; - public class QueryData { - public QueryData(String query, Date date, String domain) { + public QueryData(String query, long date, String domain) { this.query = query; this.date = date; this.domain = domain; } private final String query; - private final Date date; + private final long date; private final String domain; public String getDomain() { @@ -25,7 +23,7 @@ return query; } - public Date getDate() { + public long getDate() { return date; } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java index 0b8deb4..420b5ec 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java @@ -295,7 +295,7 @@ isExistsValue = (data != null); if (isExistsValue) { - TimeSpan span = DateTime.getNow().subtract(data.getDate()); + TimeSpan span = DateTime.getNow().subtract(new Date(data.getDate())); if (span.Days >= 1) { IsFromYesterday = true; } @@ -360,7 +360,7 @@ // An expression is considered safe if matches a trivial search. data = new QueryData(curSyntaxChecker.generateQueryFromSyntaxContainer(searchObj, isSafe), - new Date(), + DateTime.getNow().getTime(), queryDomain); // when looking for tags , the query contains all parent children tag id's // statically, therefore , in order to reflect changes in the parent tree -- To view, visit http://gerrit.ovirt.org/22144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9eb83c123a4fd9a1b2abc3bdb74d91a1391245d2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
