Roy Golan has posted comments on this change.
Change subject: core, engine: sPAPR VLAN support
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmInterfaceType.java
Line 17: spaprVlan(4, "sPAPR VLAN", "spapr-vlan", 1000);
Line 18:
Line 19: private int value;
Line 20: private String description;
Line 21: private String internalName;
is this same as the storage diskInterface issue? a member for a name that
supports "-" ?
you could override toString() or name() methods and just replace the "_" with
"-".
way cleaner than a whole new member which has the exact name for all
thoughts?
Line 22: private int speed;
Line 23: private static final Map<Integer, VmInterfaceType> mappings = new
HashMap<Integer, VmInterfaceType>();
Line 24:
Line 25: static {
--
To view, visit http://gerrit.ovirt.org/19878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12b9d760631200a9ae6508ecceb150854b2e9e6b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
