Allon Mureinik has posted comments on this change.
Change subject: engine: Use getFileStats to retrieve iso and floppy files
......................................................................
Patch Set 6:
(1 comment)
....................................................
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 221: select
fn_db_add_config_value('HotPlugDiskSnapshotSupported','false','3.2');
Line 222: select fn_db_add_config_value('GetFileStats','false','3.0');
Line 223: select fn_db_add_config_value('GetFileStats','false','3.1');
Line 224: select fn_db_add_config_value('GetFileStats','false','3.2');
Line 225: select fn_db_add_config_value('GetFileStats','false','3.3');
@Eli, according to my understanding, we do /not/ insert default values to the
database.
Here, the default is true, and it holds for version>=3.4.
Is this not the correct way to go?
Line 226:
Line 227: -- by default use no proxy
Line 228: select fn_db_add_config_value('SpiceProxyDefault','','general');
Line 229:
--
To view, visit http://gerrit.ovirt.org/21524
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I735d2c9343fe791e0890b4a6cc9f12c74462b3f0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
