Ori Liel has posted comments on this change.
Change subject: restapi: RSDL metadata for gluster related REST api
......................................................................
Patch Set 5: (10 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 1982: search: {context: query, type: 'xs:string', value: query,
required: false}
For a collection to be searchable, there has to be explicit Backend support
(it's not generic, you don't get it 'for free'). So unless *you* implemented
search for Gluster Volumes in the Backend, the user will not be able to search.
So, unless you did indeed implement this in Backend - please remove this url
parameter
Line 1983: case_sensitive: {context: matrix, type: 'xs:boolean', value:
true|false, required: false}
Same for this url parameter, which is relevant for searches.
Line 1993: gluster_volume.gluster_bricks--COLLECTION:
{gluster_brick.server_id: 'xs:string', gluster_brick.brick_dir: 'xs:string'}
If Brick is a business entity, it's added in it's own context, so this line
should be deleted.
Line 2000: gluster_volume.gluster_options--COLLECTION:
{gluster_option.key: 'xs:string', gluster_option.value: 'xs:string'}
If Option is a business entity, it's added in it's own context, so this line
should be deleted.
Line 2009: optionalArguments: {action.force: 'xs:boolean'}
just curious - what does this parameter mean?
Line 2024: parameterType: GlusterBricks
Should be GlusterBrick, single
Line 2027: gluster_bricks--COLLECTION: {gluster_brick.server_id:
'xs:string', gluster_brick.brick_dir: 'xs:string'}
this should change accordingly
Line 2034: parameterType: GlusterOptions
Option, single
Line 2037: gluster_options--COLLECTION: {gluster_option.key:
'xs:string', gluster_option.value: 'xs:string'}
Accordingly...
Line 2041: - name:
/api/clusters/{cluster:id}/glustervolumes/{glustervolume:id}/bricks/{brick:id}/replace|rel=replace
I assume replace is more than just add and delete, right? Meaning, it has an
added business value, correct?
--
To view, visit http://gerrit.ovirt.org/3918
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2883e452b8f6bc4b51bd2199fbd712f56dd96ab5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Eoghan Glynn <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
