Vitor de Lima has posted comments on this change. Change subject: core: set address explicitly for VirtIO-SCSI devices ......................................................................
Patch Set 3: Code-Review+1 Looks good to me. Maybe some function checking if the user added more disks than the maximum supported by the VirtIO SCSI controller would be nice, but this probably should be included in another patch. This limit is quite high, as I far as I could know by looking at the "include/hw/virtio/virtio-scsi.h" in the QEMU source code. -- To view, visit http://gerrit.ovirt.org/21812 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee79ff3f72b8018d0c26b37503f480643a845765 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
