Oved Ourfali has posted comments on this change. Change subject: packaging: added override file for application context files ......................................................................
Patch Set 5: Overall it looks good. Just have two questions (better commit message to answer those could also be nice): 1. In the setup you copy the files from the server-customization to the WEB-INF directory. Won't two files exist, your override and the original one? 2. You once changed the applicationContext-security-web.xml file, and now the applicationContext.xml file. Is that intentionally? Assuming you verified the two points above, then you have +1 from me. -- To view, visit http://gerrit.ovirt.org/20833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f9e637dd385dfd6928a511ec801759616746782 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
