Ayal Baron has posted comments on this change.
Change subject: engine: Split nfs, posix and iscsi logic when creating
connection struct
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
Line 82: conParams.put("user", connection.getuser_name(), "");
Line 83: conParams.put("password", connection.getpassword(),
"");
Line 84: break;
Line 85:
Line 86: case POSIXFS:
how can storage type be POSIXFS if the pool doesn't support it?
Line 87: // For mnt_options and vfs_type - if they are null
Line 88: // or empty we should not send a key with an empty
value
Line 89: conParams.putIfNotEmpty("mnt_options",
connection.getMountOptions());
Line 90: conParams.putIfNotEmpty("vfs_type",
connection.getVfsType());
Line 86: case POSIXFS:
Line 87: // For mnt_options and vfs_type - if they are null
Line 88: // or empty we should not send a key with an empty
value
Line 89: conParams.putIfNotEmpty("mnt_options",
connection.getMountOptions());
Line 90: conParams.putIfNotEmpty("vfs_type",
connection.getVfsType());
because it's not supported for nfs
Line 91: break;
Line 92:
Line 93: case NFS:
Line 94: // storage_pool can be null when connecting through
vds which has no storage pool
--
To view, visit http://gerrit.ovirt.org/21971
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba33ea1b40ef1eb9c74cad7b0531dc26e21c049a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
